Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting started with spring java guide #3897

Merged
merged 25 commits into from
Jun 18, 2024

Conversation

christinaausley
Copy link
Contributor

@christinaausley christinaausley commented Jun 6, 2024

Description

Related to https://github.com/camunda/product-hub/issues/2146.

Drafted Spring/Java guide based on developed work by @pepopowitz in https://github.com/camunda/camunda-8-get-started-spring.

Need to

  • Add to sidebar -- where would we want this to live?
  • Backport upon approval

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@christinaausley christinaausley added component:docs Documentation improvements, including new or updated content dx Documentation infrastructure typically handled by the Camunda DX team labels Jun 6, 2024
@christinaausley christinaausley self-assigned this Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@pepopowitz pepopowitz changed the title setting started with spring java guide getting started with spring java guide Jun 10, 2024
Copy link
Collaborator

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Christina!

I have a few non-blocking comments, and a handful of comments to add more precise language. The biggest concern for me is introducing code changes one snippet at a time -- I think it will lead to more mistakes, as I describe inline.

docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
@christinaausley
Copy link
Contributor Author

@pepopowitz @akeller This is ready for another review 👍

Copy link
Collaborator

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are exactly what I was looking for, thank you!!!

Only one of my changes is blocking, but I do think it's important. I also added many non-blocking suggestions for your consideration.

docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
@christinaausley christinaausley requested a review from akeller June 17, 2024 11:33
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - this should go in the Guides sidebar as part of the getting started area. This will also kick-off some rework to make this area less SaaS-only, but that's outside the scope of this PR.

Keep in mind the versions when backporting. So for 8.5, yes it absolutely makes sense to keep the pom.xml file dependency at 8.5+. For /next/ you can do anything 8.5.0+, so incorporating the changes up until 8.6.0.

Are there any changes that need to be made to the code repo? Those need to be taken care of so we can merge and release this.

@akeller
Copy link
Member

akeller commented Jun 17, 2024

@crobbins215 will you review or should we merge?

@crobbins215
Copy link
Contributor

@crobbins215 will you review or should we merge?

I have read over it, and it looks good, I've not tested it for myself, time-limited at the moment, so as long as it's all working fine from the reviews it has had I'm happy to get it merged.

@christinaausley christinaausley merged commit 7ca2db8 into main Jun 18, 2024
9 checks passed
@christinaausley christinaausley deleted the getting-started-spring-java branch June 18, 2024 16:24
@akeller
Copy link
Member

akeller commented Jun 18, 2024

Added the alpha3 label retroactively since it's being delivered between alpha2 and alpha3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content dx Documentation infrastructure typically handled by the Camunda DX team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants