-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getting started with spring java guide #3897
Conversation
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
Co-authored-by: Amara Graham <[email protected]>
Co-authored-by: Amara Graham <[email protected]>
Co-authored-by: Amara Graham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Christina!
I have a few non-blocking comments, and a handful of comments to add more precise language. The biggest concern for me is introducing code changes one snippet at a time -- I think it will lead to more mistakes, as I describe inline.
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
@pepopowitz @akeller This is ready for another review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are exactly what I was looking for, thank you!!!
Only one of my changes is blocking, but I do think it's important. I also added many non-blocking suggestions for your consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - this should go in the Guides sidebar as part of the getting started area. This will also kick-off some rework to make this area less SaaS-only, but that's outside the scope of this PR.
Keep in mind the versions when backporting. So for 8.5, yes it absolutely makes sense to keep the pom.xml
file dependency at 8.5+. For /next/
you can do anything 8.5.0+, so incorporating the changes up until 8.6.0.
Are there any changes that need to be made to the code repo? Those need to be taken care of so we can merge and release this.
@crobbins215 will you review or should we merge? |
I have read over it, and it looks good, I've not tested it for myself, time-limited at the moment, so as long as it's all working fine from the reviews it has had I'm happy to get it merged. |
Added the alpha3 label retroactively since it's being delivered between alpha2 and alpha3. |
Description
Related to https://github.com/camunda/product-hub/issues/2146.
Drafted Spring/Java guide based on developed work by @pepopowitz in https://github.com/camunda/camunda-8-get-started-spring.
Need to
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).